search

microsoft / react-native-adaptivecards

React Native renderer for AdaptiveCards
https://microsoft.github.io/react-native-adaptivecards/
80 stars 21 forks source link

Out of sync with NPM published version #7

Closed Kevin-Chung closed 5 years ago

Kevin-Chung commented 5 years ago

The repository's master branch has code that's ahead of what is currently published on NPM. Anyway we can get this to either be reverted, or have the version on NPM be updated to be in sync?

DongyuZhao commented 5 years ago

Hi Kevin: The 0.2.0 version on npm is the same version of the master branch. Please check it.

获取 Outlook for iOShttps://aka.ms/o0ukef

收件人: Kevin-Chung notifications@github.com 发送时间: 星期五, 十一月 30, 2018 9:54 下午 收件人: Microsoft/react-native-adaptivecards 抄送: Subscribed 主题: [Microsoft/react-native-adaptivecards] Out of sync with NPM published version (#7)

The repository's master branch has code that's ahead of what is currently published on NPM. Anyway we can get this to either be reverted, or have the version on NPM be updated to be in sync?

― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Freact-native-adaptivecards%2Fissues%2F7&data=02%7C01%7C%7Ce3a5e6fdea674fc40b2108d656cb5fca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636791828820969841&sdata=iynp%2F56OpFEnHn0yY4QSn6xaiBRjCbXt0g6%2BH%2FIwX44%3D&reserved=0, or mute the threadhttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIEGLbPOcIf2pu5F0dW7-gl3B7tEp8Y2ks5u0TiegaJpZM4Y7th-&data=02%7C01%7C%7Ce3a5e6fdea674fc40b2108d656cb5fca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636791828820969841&sdata=jHrRd0%2BWKRplz7j757FRi%2FKl0BeHnQsEzGcCA8lUid4%3D&reserved=0.

Kevin-Chung commented 5 years ago

Thanks for pointing that out, is there a reason that its not the default version?

DongyuZhao commented 5 years ago

In the previous version, there were some undocumented internal required control(e.g. PeoplePicker and Counter). In the coming version of standard adaptive card, all the requirement for these undocumented controls could be fulfill by combining the new actions and elements in it. Thus we decide to remove undocumented controls and release the renderer following the standard. This is what we do for 0.2.0.

However, 0.1.0 has some accessibility issue and we need to fix it immediately and do not want to break production rely on those undocumented control, we released 0.1.1 and 0.1.2 to fix them.

As 0.1.2 is released after 0.2.0, npm auto pick 0.1.2 as the default version now.