microsoft / react-native-code-push

React Native module for CodePush
http://appcenter.ms
Other
8.97k stars 1.47k forks source link

RecreateReactContextInBackground does not exist in RN-Windows 50 #1078

Closed adricl closed 6 years ago

adricl commented 6 years ago

Hello All,

I am having an issue where RecreateReactContextInBackground does not exist in React Native 50 RC2.

I think its due to ReactPage being Obsoleted. When I add the project to the sample react native windows project I get the following error in Visual Studio 2017.

Error CS1061 'ReactInstanceManager' does not contain a definition for 'RecreateReactContextInBackground' and no extension method 'RecreateReactContextInBackground' accepting a first argument of type 'ReactInstanceManager' could be found (are you missing a using directive or an assembly reference?) CodePush C:\New Pos\migration\node_modules\react-native-code-push\windows\CodePushNativeModule.cs 263 Active

I have checked in React Native and this no longer exits.

adricl commented 6 years ago

1051 This is the fix for this issue.

max-mironov commented 6 years ago

Hey @adricl, closing this due to fix merged!