microsoft / react-native-code-push

React Native module for CodePush
http://appcenter.ms
Other
8.98k stars 1.47k forks source link

install update correctly after app installed,but It always rollback after restart the app #1725

Closed Mlobaievskyi closed 4 years ago

Mlobaievskyi commented 4 years ago

Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):

Steps to Reproduce

  1. Configure coodepush correctly
  2. Push update to production branch
  3. Immediate update don't work so update on app resume
  4. Hard close app and open again

Expected Behavior

Update from codepush already present

Actual Behavior

App rolled back to initial state and codepush doesn't apply anymore unless new update uploaded too codepush

Environment

ahartzog commented 4 years ago

See https://github.com/microsoft/react-native-code-push/issues/1704

There's other similar issues too. I haven't found a solution.

seamereth commented 4 years ago

Having the same issue here.

dwilt commented 4 years ago

Same exact issue here.

ahartzog commented 4 years ago

@dwilt - try removing the --development flag from your codepush appcenter-cli build command. That resolved the issue for me.

Mlobaievskyi commented 4 years ago

@ahartzog I'm not using --development flag

Mlobaievskyi commented 4 years ago

code-push release-react <prodIOSBranch> ios -d Production --privateKeyPath ./private.pem --plistFile <pathToPlistFile>

dwilt commented 4 years ago

@ahartzog thanks for the reply, but as @Mlobaievskyi, I'm not using the development flag either

ahartzog commented 4 years ago

Ah, must be some other issue going on as well then.

sivakumar-cf commented 4 years ago

I am also facing the same issue, I'm not using --development flag. Any update on this issue?

luskin commented 4 years ago

removing the --development flag fixes the issue of app crashing immediately following an update, however this issue (which exists for us as well) is that after a successful update and relaunching of the app it rolls itself back to the previous version.

zezest commented 4 years ago

I had same issue, but now it is well then. this is my solution.

ios/<app_name>/AppDelegate.m

// add
#import <CodePush/CodePush.h>

and change

// before
return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];

// after
return [CodePush bundleURL];

Environment

https://docs.microsoft.com/en-us/appcenter/distribution/codepush/react-native#plugin-configuration-ios

luskin commented 4 years ago

@zezest - yes, this will seem to work but if you close the app and then re-open it (don't rebuild) it will revert back to initial bundle. If it is somehow working for you across multiple opens of the app on the same build then good for you, but for the rest of us it reverts.

Mlobaievskyi commented 4 years ago

@zezest yes, it work for me also. Not sure when that code was deleted from my app, probably when I upgraded to the new react-native version. I followed back this instructions and it work again https://github.com/microsoft/react-native-code-push/blob/master/docs/setup-ios.md

Mlobaievskyi commented 4 years ago

Probably issue not with code-push but with configuration

mcruz20 commented 4 years ago

Any updates on this?

andreidubov commented 4 years ago

Hi @Mlobaievskyi , Thank you for reporting!

As I can see, you are using react-native v0.61.4 and react-native-code-push v5.7.0 but these are incompatible versions, you can take a look at supporting CodePush versions here: https://github.com/microsoft/react-native-code-push#supported-react-native-platforms

Not so long ago we released a new version of Code Push which supports react-native v0.60-v0.61. All steps for installing the latest version of the plugin are described in our documentation: https://github.com/microsoft/react-native-code-push/blob/master/docs/setup-ios.md

I'm going to close this issue for now. Please let me know if you have any other questions.

Saurabh4626 commented 4 months ago

this issue is still there? Has anyone figured out a solution

DordeDimitrijev commented 4 months ago

Hello @Saurabh4626 thank you for reaching out, could you please tell me which react-native-code-push and react-native version are you using?

Saurabh4626 commented 4 months ago

@DordeDimitrijev, here you go "react-native": "^0.72.6", "react-native-code-push": "^8.1.0"

DordeDimitrijev commented 4 months ago

Hello @Saurabh4626 could you try using react-native 0.71.X version since there might be compatability issues with codepush and 0.72 react-native version, and let me know if the issue is still ocurring?

fragilehm commented 2 months ago

@DordeDimitrijev I am having the same issue: react-native: 0.73.9 react-native-code-push: 8.3.1

For the context, I was upgrading the react-native from 0.72.8 to 0.73.9 and the codepush was upgraded from 8.1.1 to 8.3.1 after that the codepush update on android only stopped working.

DordeDimitrijev commented 2 months ago

Hello @fragilehm thank you for reaching out. I have several questions which can help me further analyze your issue.

Ideally it'd be nice if you could share small demo app with me where i can reproduce such behavior.

fragilehm commented 2 months ago

Hello @fragilehm thank you for reaching out. I have several questions which can help me further analyze your issue.

  • Are you using custom code push server, if so can you try out using default appcenter codepush server?
  • If you don't use custom code push server, could you please provide logs from logcat when you apply update to your app?

Ideally it'd be nice if you could share small demo app with me where i can reproduce such behavior.

@DordeDimitrijev thanks for your reply: I have missed the following while migrating to 0.73: image

Now it works as expected.