Codepush doesn't work on iOS in release mode

microsoft / react-native-code-push

React Native module for CodePush

http://appcenter.ms

Other

8.99k stars 1.47k forks source link

Codepush doesn't work on iOS in release mode #2259

Closed samouds closed 2 years ago

samouds commented 2 years ago

Hello,

i am using 7.0.4 version and it works on android. I have followed all the steps but I have some issue on iOS (tvos) :

When I run the app in release mode on Xcode, I see the update dialog and the bundle is updated.
When I push the app to TestFlight, I get the update dialog too but the bundle isn't update.

How can I get logs to see what's going on in release mode on TestFlight ?

samouds commented 2 years ago

Hello,

I got more details when I run the app in Release mode on the Apple TV

[javascript] [CodePush] Downloading package.
[javascript] [CodePush] An unknown error occurred.
[javascript] [CodePush] You don’t have permission to save the file “CodePush” in the folder “Application Support”.

rkaartikeyan commented 2 years ago

In Simulator it's not working, can you try on real device?

samouds commented 2 years ago

@rkaartikeyan it's working in the simulator but not on real device.

rkaartikeyan commented 2 years ago

seems it's expecting permission for write file on device.

yz1311 commented 2 years ago

Same to me.Android real device and ios simulator works fine except ios real device.

yz1311 commented 2 years ago

Same to me.Android real device and ios simulator works fine except ios real device.

ok, enable ios hermes,work fine now.

josephk96 commented 2 years ago

Same to me.Android real device and ios simulator works fine except ios real device.

ok, enable ios hermes,work fine now.

Thanks @yz1311 ! Your solution worked. I'm not sure why though, before upgrading to RN 0.68.2 from 0.63.3, it was working properly even without Hermes, but after upgrading my release iOS app stopped downloading CodePush bundles.

https://github.com/microsoft/appcenter-cli/blob/6dad658ce6b97d2e8f5c382914d673983ee81618/src/commands/codepush/release-react.ts#L233 appcenter-cli also seems to be converting js bundles to hermes if hermes is enabled, https://github.com/microsoft/appcenter-cli/blob/6dad658ce6b97d2e8f5c382914d673983ee81618/src/commands/codepush/lib/react-native-utils.ts#L490 so I'm really confused as to why we have to enable hermes on iOS for it to work

ghost commented 2 years ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

ghost commented 2 years ago

This issue will now be closed because it hasn't had any activity for 15 days after stale. Please feel free to open a new issue if you still have a question/issue or suggestion.

crewtaylorfd commented 1 year ago

I am trying to run on tvOS and it is not working on a real device with hermes enabled. I get the following logs.


[CodePush] Downloading package.
[CodePush] An unknown error occurred.
[CodePush] You don’t have permission to save the file “CodePush” in the folder “Application Support”.