Closed khushbujilka22 closed 5 months ago
@khushbujilka22 , thanks for reaching out!
Does this issue happen every time, or just sometimes? Also, could you make a simple demo app that shows the problem?
There's a similar issue you might find relevant: https://github.com/microsoft/react-native-code-push/issues/2133
happening to me as well
I'm facing the exactly same issue. Every updates are rolled back after downloaded. Any fix?
For me, I used a variable "hasListeners" to track whether the RN side has been initialized with listeners set up, along with the start and stopObserving methods that I override on the RCTEventEmitter. If this is true, then I allow events to be sent (you can send all events through one method). I use a guard statement within that function. Hope this helps!
For me, I used a variable "hasListeners" to track whether the RN side has been initialized with listeners set up, along with the start and stopObserving methods that I override on the RCTEventEmitter. If this is true, then I allow events to be sent (you can send all events through one method). I use a guard statement within that function. Hope this helps!
Can you share the code to patch? I'm new to objective-c and iOS development.
@griffinbaker12 If I understand correctly, Is this what you mean by adding code to CodePush.m, like sending event to JavaScript's startObserving? https://reactnative.dev/docs/0.72/native-modules-ios#sending-events-to-javascript
I used Swift in my example, but am happy to show you that if you still find it helpful.
I used Swift in my example, but am happy to show you that if you still find it helpful.
Even if you're Swift, I think it would be helpful to see how you adapted it.
Hi guys @mununki, @griffinbaker12 did you found the solution? If not, could you please confirm what this issue still persist on latest version (8.2.1)?
Mine was resolved https://github.com/microsoft/react-native-code-push/issues/2639
This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.
This issue will now be closed because it hasn't had any activity for 15 days after stale. Please feel free to open a new issue if you still have a question/issue or suggestion.
Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):
while downloading the code push update, it suddenly crashed with an exception.
Environment
This is happening with IOS in release and debug build both.