microsoft / react-native-code-push

React Native module for CodePush
http://appcenter.ms
Other
8.98k stars 1.47k forks source link

Some assets are not getting bundled in codepush #2616

Closed AmitSingh12345678 closed 3 months ago

AmitSingh12345678 commented 11 months ago

Steps to Reproduce

1.init project and install react-native-code-push package

  1. Using a asset of format lottie(abc.lottie) like this: {require('/abc.lottie')}
  2. code-push release

Expected Behavior

Every assets including dotlottie format should work fine.

Actual Behavior

Everything works fine, except dotlottie format assets are not showing after codepush release, but was working fine in debug and release mode.

Environment

bhavzie commented 11 months ago

We are facing this as well, our hunch is that codepush release-react while bundling the JS doesn't respect the local metro.config.js where we have specified how to resolve certain asset extensions (.lottie)

manikandanb24 commented 11 months ago

We're also facing this. When codepush bundle gets replaced. Lottie is no longer being visible.

walterholohan commented 11 months ago

Yep same here, however it is only on Android where the .lottie files do not work

matinzd commented 11 months ago

Yep same here, however it is only on Android where the .lottie files do not work

The reason is because on Android release mode, react native bundles all the assets in raw folder whearas on iOS it uses network call. Seems like mostly code push is the problem. Has anyone tried expo updates? Is it the same story there?

a-petrenko-muse commented 11 months ago

On my project I use react-native-asset to solve this problem, it took a decent amount of time, as there were more than 800 asset files

AmitSingh12345678 commented 11 months ago

On my project I use react-native-asset to solve this problem, it took a decent amount of time, as there were more than 800 asset files

@a-petrenko-muse Can you please tell what is this issue with codepush and how do you get to know that react-native-asset will solve this problem?

mrtawil commented 11 months ago

+1

hardik-flyfin commented 11 months ago

Are there any updates?

joaojoseleal commented 10 months ago

+1

MikhailSuendukov commented 9 months ago

Could you please confirm what this issue still persist on latest version (8.2.1)? If no could you please confirm that the problem persists when linking assets using react-native-asset package?

hardik-flyfin commented 7 months ago

Active

quoctruongkt commented 6 months ago

+1

quoctruongkt commented 6 months ago

I am also stuck because of this problem. Has anyone handled it yet?

ToanMonkey commented 6 months ago

Tôi cũng bị mắc kẹt vì vấn đề này. Đã có ai xử lý được chưa?

me too :(

DmitriyKirakosyan commented 5 months ago

@hardik-flyfin, @quoctruongkt, @ToanMonkey, please share information about the versions of CodePush and ReactNative. Please try using react-native-asset as a workaround.

ToanMonkey commented 5 months ago

@hardik-flyfin, @quoctruongkt, @ToanMonkey, please share information about the versions of CodePush and ReactNative. Please try using react-native-asset as a workaround.

I initially used -Code push: 7.1.0 -React Native : 0.70.6 Currently I have upgraded to React Native: 0.71.19 but still have the same problem

DmitriyKirakosyan commented 5 months ago

@ToanMonkey please try updating codepush to 8.2.2

quoctruongkt commented 5 months ago

@ToanMonkey please try updating codepush to 8.2.2

I tried updating codepush to version 8.2.2 but the problem is still not resolved

DmitriyKirakosyan commented 3 months ago

It would be greatly appreciated if anyone could provide a demo application to reproduce and debug the issue.

DmitriyKirakosyan commented 3 months ago

Closing due to inactivity.

tevfik1 commented 2 months ago

+1