microsoft / react-native-code-push

React Native module for CodePush
http://appcenter.ms
Other
8.98k stars 1.47k forks source link

React-native 0.72 requires higher minimum SDK version for windows. #2624

Closed VMBindraban closed 8 months ago

VMBindraban commented 11 months ago

Steps to Reproduce

  1. Install react-native
  2. npm install codepush
  3. Install react-native-windows (https://reactnative.dev/docs/out-of-tree-platforms)
  4. npx react-native run-windows

Expected Behavior

To build app.

Actual Behavior

React-native-windows 0.72 has minimum target version of 10.0.17763.0. (October 2018 update) See: https://microsoft.github.io/react-native-windows/docs/win10-compat

The current minimum version is set to 10.0.17134.0.

 × Build failed with message C:\Users\NUCPC\.nuget\packages\microsoft.ui.xaml\2.8.0\build\Common.targets(10,5): error : 
Microsoft.UI.Xaml nuget package requires TargetPlatformMinVersion >= 10.0.17763.0 (current project is 17134) 
[C:\Users\NUCPC\***--app\node_modules\react-native-code-push\windows\CodePush\CodePush.vcxproj]. 
Check your build configuration.

Command failed. Re-run the command with --logging for more information.

Also, the minimum Windows OS version is set to 10.0.18362.0.

As of Visual Studio 2019 (v16 or v142) and Visual Studio 2022(v17 or v143) you can simply specify "10.0". This allows a lot more flexibility to the developer or build machine as there is a growing number of different windows 10 SDK out there now.

Environment

VMBindraban commented 8 months ago

Bump?