search

microsoft / react-native-code-push

React Native module for CodePush
http://appcenter.ms
Other
8.99k stars 1.48k forks source link

Codepush Rollback Issue on Android #2677

Closed shri2kpro closed 6 months ago

shri2kpro commented 8 months ago

Handling for rollbacks, when the app starts in background.

MikhailSuendukov commented 8 months ago

Hello and thanks for your contribution! Apparently this PR is a continuation of this PR. I looked at your changes, but my concerns about the following issue are still relevant.

I have concerns that in this case the case will not be processed when a rollback needs to be performed due to an unsuccessful update download or invalid jsbundle. Which actually checks by calling notifyAppReady when the application is rendered. What will happen in this case? I think this case needs to be handled too.

What do you think about it?

DmitriyKirakosyan commented 6 months ago

Closing. Please reopen if you are still interested.