upgrade gallery to 0.74

[TatianaKapos]

Description

upgrade Gallery to 0.74

[TatianaKapos]

There were more changes in the previous PR: #428 (comment) Do we not need those extra version bumps?

But as is, this looks fine. Same changes to the app template as far as I can tell.

Ah! Yes some of those package bumps were me trying to get babel to work before I realized we weren't using the correct preset. I'll add back the ones that were upgraded in 0.74 though :)

[chrisglein]

CI continues to fail on this:

× Building Solution
- Build failed with message 3:34>D:\a\_work\1\s\node_modules\react-native-windows\codegen\NativePlatformConstantsWinSpec.g.h(75,39): error C3615: constexpr function 'winrt::Microsoft::ReactNative::TurboModuleSpec::CheckMethodsHelper' cannot result in a constant expression (compiling source file D:\a\_work\1\s\node_modules\react-native-windows\Microsoft.ReactNative\Modules\PlatformConstantsWinModule.cpp) [D:\a\_work\1\s\node_modules\react-native-windows\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]. Check your build configuration.
× Build failed with message 3:34>D:\a\_work\1\s\node_modules\react-native-windows\codegen\NativePlatformConstantsWinSpec.g.h(75,39): error C3615: constexpr function 'winrt::Microsoft::ReactNative::TurboModuleSpec::CheckMethodsHelper' cannot result in a constant expression (compiling source file D:\a\_work\1\s\node_modules\react-native-windows\Microsoft.ReactNative\Modules\PlatformConstantsWinModule.cpp) [D:\a\_work\1\s\node_modules\react-native-windows\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]. Check your build configuration.
- It is possible your installation is missing required software dependencies. Dependencies can be automatically installed by running D:\a\_work\1\s\node_modules\react-native-windows\scripts\rnw-dependencies.ps1 from an elevated PowerShell prompt.
For more information, go to http://aka.ms/rnw-deps
× It is possible your installation is missing required software dependencies. Dependencies can be automatically installed by running D:\a\_work\1\s\node_modules\react-native-windows\scripts\rnw-dependencies.ps1 from an elevated PowerShell prompt.
For more information, go to http://aka.ms/rnw-deps
Command failed with error MSBuildError: 3:34>D:\a\_work\1\s\node_modules\react-native-windows\codegen\NativePlatformConstantsWinSpec.g.h(75,39): error C3615: constexpr function 'winrt::Microsoft::ReactNative::TurboModuleSpec::CheckMethodsHelper' cannot result in a constant expression (compiling source file D:\a\_work\1\s\node_modules\react-native-windows\Microsoft.ReactNative\Modules\PlatformConstantsWinModule.cpp) [D:\a\_work\1\s\node_modules\react-native-windows\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]
##[error]Cmd.exe exited with code '2302'.

source

This doesn't repro for me when building the branch locally.

Failure first occurs from building these files:

• Timing.cpp
• NativeModulesProvider.cpp

(note: RNW files, not gallery files)

There doesn't seem to be any CI errors when building these samples on 0.74 though: https://github.com/microsoft/react-native-windows-samples/pull/937 @tatianakapos Are there differences in the CI between the repos? Or differences between construction of the apps? If we want a third example, maybe you can help me onboard better CI validation of Artificial Chat so this PR would give us signal? https://github.com/chrisglein/artificial-chat/pull/145

[TatianaKapos]

@chrisglein Interestingly, this is the same error message from this issue on our repo which has to do with switching to C++20, I'm not sure why only the Gallery CI would be hitting this.

A big comparison between Gallery and our samples repo is that Gallery uses ADO while Samples uses github workflows. Gallery also uses yarm instead of yarn but we use yarm in the main repository.

More than happy to add CI to Artificial Chat though, it would be helpful to have multiple apps running the same build structure.