search

microsoft / react-native-gallery

This repo contains the react-native Gallery app created by Microsoft
MIT License
149 stars 44 forks source link

Chore: Update react-native-lottie #473

Open Saadnajmi opened 2 months ago

Saadnajmi commented 2 months ago

Description

Why

Our version of Lottie doesn't support macOS

What

Update Lottie to the latest, which does support macOS

Microsoft Reviewers: Open in CodeFlow
chrisglein commented 2 months ago

CI is failing with this:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(414,5): error MSB3202: The project file "D:\a_work\1\s\node_modules\lottie-react-native\src\windows\cppwinrt\LottieReactNative.vcxproj" was not found. [D:\a_work\1\s\windows\rngallery.sln]

Perhaps that patch file that was removed is still needed?

Saadnajmi commented 2 months ago

CI is failing with this:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.targets(414,5): error MSB3202: The project file "D:\a_work\1\s\node_modules\lottie-react-native\src\windows\cppwinrt\LottieReactNative.vcxproj" was not found. [D:\a_work\1\s\windows\rngallery.sln]

Perhaps that patch file that was removed is still needed?

It seems so. I removed the patch to see if the latest version had the fix. Glad to see the CI caught it doesn't. I'll update the patch to reflect the new version with the changes.