search

microsoft / react-native-gallery

This repo contains the react-native Gallery app created by Microsoft
MIT License
149 stars 44 forks source link

Update bundle entry file when building in Release mode #488

Closed Yajur-Grover closed 3 weeks ago

Yajur-Grover commented 1 month ago

Description

When trying to build Gallery in Release mode in order to publish the update to 0.75 to the store, was hitting the following error:

Error MSB3073 The command "npx react-native bundle --platform windows --entry-file "index.js" --bundle-output "C:\new-account-repos\react-native-gallery\windows\rngallery\Bundle\index.windows.bundle" --assets-dest "C:\new-account-repos\react-native-gallery\windows\rngallery\Bundle" --dev false --reset-cache --sourcemap-output "C:\new-account-repos\react-native-gallery\windows\x64\Release\rngallery\sourcemaps\react\index.windows.bundle.packager.map" --minify false" exited with code 1. rngallery C:\new-account-repos\react-native-gallery\node_modules\react-native-windows\PropertySheets\Bundle.Common.targets 16
Error The resource C:\new-account-repos\react-native-gallery\index.js was not found. rngallery C:\new-account-repos\react-native-gallery\windows\rngallery\EXEC 1

This PR updates the <BundleEntryFile> for Gallery from index.js, which is defined by default here. to index.ts.

Why

Fix error above to allow store publish.

What

Edit <BundleEntryFile> to index.ts.

Microsoft Reviewers: Open in CodeFlow