search

microsoft / react-native-gallery

This repo contains the react-native Gallery app created by Microsoft
MIT License
149 stars 44 forks source link

Add accessibility announcement to 'Copy from Clipboard' buttons #507

Closed Yajur-Grover closed 1 day ago

Yajur-Grover commented 3 days ago

Description

Adds an accessibility announcement to indicate success when using the 'Copy to Clipboard' buttons in the app.

Why

Resolves #495

What

Added an accessibility announcement call to the CopyToClipboard component.

Screenshots

N/A. Tested with Narrator and it announces 'Copied' every time the button is pressed.

Microsoft Reviewers: Open in CodeFlow
chrisglein commented 2 days ago

Saw update to announce message on copy. 👍 Add to paste as well? (matching WinUI Gallery)

Yajur-Grover commented 1 day ago

Saw update to announce message on copy. 👍 Add to paste as well? (matching WinUI Gallery)

Update to paste where? This PR updates the ClipboardExamplePage buttons.

chrisglein commented 1 day ago

Saw update to announce message on copy. 👍 Add to paste as well? (matching WinUI Gallery)

Update to paste where? This PR updates the ClipboardExamplePage buttons.

I got confused between the 2 reviews. Ignore me :)