Closed gabrieldonadel closed 7 months ago
Hi @Saadnajmi, Is there something else that needs to be addressed here to get this merged?
Hi @Saadnajmi, Is there something else that needs to be addressed here to get this merged?
Nope, just a nudge! If you also want this for 0.73
, could you cherry-pick the change and make a PR against the 0.73
branch? It's easier for me to approve/merge that way
Please select one of the following
Summary:
The hermes script (hermes-utils.rb) uses the react-native-macos version to check for available hermes artifacts on maven but the problem is that whenever react-native-macos version gets ahead of react-native there are no prebuilds to be found and hermes will try to build from source (which does not work).
This PR fixes this by checking the latest available patch version for a given version and using that as the hermes-version
Changelog:
[MACOS] [FIXED] - Fix Hermes version mismatch
Test Plan:
Enable hermes on rntester, set react-native package.json version to 0.73.2, run pod install and certify it's downloading the prebuild tarball