fix(macOS): Don't use iOS deployment target for macOS - Githubissues

microsoft / react-native-macos

A framework for building native macOS apps with React.

https://microsoft.github.io/react-native-windows/

MIT License

3.45k stars 132 forks source link

fix(macOS): Don't use iOS deployment target for macOS #2042

Closed Saadnajmi closed 7 months ago

Saadnajmi commented 7 months ago

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[x] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary:

This PR aims to reduce the number of changes needed to add visionOS support, see: https://github.com/microsoft/react-native-macos/pull/2019

Fix two issues:

Fix some typos where we were using the iOS deployment target for macOS, and had duplicated the definition of the min_supported_versions helper method (😵‍💫)
Delete some stale pbxproj entries that don't do anything. These show up every now and then, and I didn't feel it was worth a separate PR to fix up.

Changelog:

[GENERAL] [FIXED] - Fix some typos and merge errors

Test Plan:

CI should pass.