microsoft / react-native-macos

A framework for building native macOS apps with React.
https://microsoft.github.io/react-native-windows/
MIT License
3.37k stars 129 forks source link

Fix new role prop after JS-Shim was removed by Meta #2101

Closed FalseLobster closed 3 months ago

FalseLobster commented 3 months ago

Summary:

main targeted PR of #2100

Prior to 0.73, the new role prop was remapped to accessibilityRole on the JS-side. Starting with #37304, the work needs to be completed on the native side. Since the new prop is ARIA inspired, the mappings are taking from the ARIA Core AAM which disagrees with some of the mappings used in the old accessibilityRole prop. Users of the old prop are unaffected, but the new prop will take the mappings from the spec.

Test Plan:

Tested a variety of permutations of accessibilityRole and role to confirm the behavior looks correct in Accessibility Inspector