Send mouseUp events for NSTabView

microsoft / react-native-macos

A framework for building native macOS apps with React.

https://microsoft.github.io/react-native-windows/

MIT License

3.37k stars 129 forks source link

Send mouseUp events for NSTabView #2112

Closed eablokker closed 2 months ago

eablokker commented 2 months ago

Summary:

Fix for issue #2111 (NSTabView doesn't send mouseUp event because it doesn't inherit from NSControl).

NSTabView inherits from NSView, not NSControl, so its click events aren't recorded in the _nativeTouches cache leading to mouseUp and mouseDown not firing consistently when clicking on the tab buttons.

Test Plan:

Code for custom TabView component provided in the linked issue.

Saadnajmi commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago

Azure Pipelines successfully started running 1 pipeline(s).