nit: switch setNativeProps type from any -> unknown, remove unused vars

microsoft / react-native-macos

A framework for building native macOS apps with React.

https://microsoft.github.io/react-native-windows/

MIT License

3.37k stars 129 forks source link

nit: switch setNativeProps type from any -> unknown, remove unused vars #2120

Closed servusdei2018 closed 1 month ago

servusdei2018 commented 1 month ago

resolves 1 TODO, 6 linter warnings

Summary:

The argument type of FlatListComponent.setNativeProps was changed from any to unknown to promote safer type handling
A few unused variables/imports were removed

Test Plan:

yarn lint passes successfully

Saadnajmi commented 1 month ago

Hi, unfortunately I don't think we can take this PR. Our repo being a fork of React Native, we are very careful not to make any unnecessary changes from React Native except to add macOS support, and diligently mark where we do update code

This PR should probably target React Native directly.