search

microsoft / react-native-macos

A framework for building native macOS apps with React.
https://microsoft.github.io/react-native-windows/
MIT License
3.49k stars 135 forks source link

fix: Remove flipper config from the Podfile template #2195

Closed Negan1911 closed 2 weeks ago

Negan1911 commented 2 weeks ago

Summary:

When building a new project with React Native MacOS, it would fail with this error:

Couldn't install Pods. Updating the Pods project and trying again...
Command `pod install` failed.
└─ Cause: Invalid `Podfile` file: uninitialized constant Pod::Podfile::FlipperConfiguration.

 #  from /Users/moru/Documents/Work/test_project/macos/Podfile:18
 #  -------------------------------------------
 #      # Flipper is not compatible w/ macOS
 >      :flipper_configuration => FlipperConfiguration.disabled,
 #      # An absolute path to your application root.
 #  -------------------------------------------

As, for example, here: https://github.com/microsoft/react-native-macos/issues/2164

The ongoing solution was to remove that line from the Podfile, I'm sending this PR to edit the template so that line is removed by default.

Test Plan:

I'm probably going to need some help here, not quite sure how I can create a project against my local version of react-native-macos to test this one, but I'm sure that with this line removed (and as many other issues point) the project compiles and this error is avoided.

Saadnajmi commented 2 weeks ago

Hi! Thanks for the change! I thought we had done this, but I guess not. To get this in 0.74 and 0.75, we'll have to make PRs to the 0.74-stable and 0.75-stable branch. Can I ask what version of RNM you were using that encouraged this change?

Negan1911 commented 2 weeks ago

Right now it happened to me with 0.75, I'm going to create PRs pointing to those branches and link them here in a minute!

Negan1911 commented 2 weeks ago

Looks like it was only affecting on 0.75, since it's fixed on 0.74 (#2166). I opened mine for 0.75 here: #2200.

Thanks!