search

microsoft / react-native-windows-samples

A repository showcasing React Native samples and templates for Windows, macOS, and Surface Duo.
https://microsoft.github.io/react-native-windows/
MIT License
485 stars 199 forks source link

AppServiceDemo no longer runs #968

Closed TatianaKapos closed 2 months ago

TatianaKapos commented 2 months ago

Sample

AppServiceDemo

Problem Description

AppServiceDemo hasn't been updated since 0.71 and no longer runs out-of-the-box. I have turned off the tests for PR so it stops blocking PRs but we should either update it or figure out if it needs to be deprecated!

Error Message: error C4996: 'stdext::checked_array_iterator<T*>': warning STL4043: stdext::checked_array_iterator, stdext::unchecked_array_iterator, and related factory functions are non-Standard extensions and will be removed in the future. std::span (since C++20) and gsl::span can be used instead.

Steps To Reproduce

  1. Try to run AppServiceDemo
  2. It will fail

Expected Results

It runs fine

CLI version

10.2.0

Environment

info Fetching system and libraries information...
System:
    OS: Windows 10 10.0.22631
    CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
    Memory: 39.31 GB / 63.85 GB
  Binaries:
    Node: 18.18.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 8.18.0 - ~\AppData\Roaming\npm\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK: Not Found
    Windows SDK:
      AllowDevelopmentWithoutDevLicense: Enabled
      AllowAllTrustedApps: Enabled
      Versions: 10.0.17763.0, 10.0.18362.0, 10.0.19041.0, 10.0.22000.0, 10.0.22621.0
  IDEs:
    Android Studio: AI-213.7172.25.2113.9014738
    Visual Studio: 16.11.35130.168 (Visual Studio Enterprise 2019), 17.11.35219.272 (Visual Studio Enterprise 2022)
  Languages:
    Java: 11.0.16.1 - C:\Program Files\Eclipse Adoptium\jdk-11.0.16.101-hotspot\bin\javac.EXE
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: 0.71.4 => 0.71.4
    react-native-windows: 0.71.4 => 0.71.4
  npmGlobalPackages:
    *react-native*: Not Found
info React Native v0.75.2 is now available (your project is running on v0.71.4).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.75.2
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.71.4
info For more info, check out "https://reactnative.dev/docs/upgrading".

Target Platform Version

10.0.22621

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2022

Build Configuration

Debug

chrisglein commented 2 months ago

we should either update it or figure out if it needs to be deprecated!

This sample won't be needed as we transition to Fabric, so as we struggle to keep it running on older versions it seems time to retire it. If the fix is easy, great we'll take it and keep it running. But our time is best spent translating this scenario to Fabric in the appropriate modern native way.

@TatianaKapos can you make a PR to deprecate the sample and remove from CI?