microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.36k stars 1.14k forks source link

TextInput focusable property should match react-native #10015

Open TatianaKapos opened 2 years ago

TatianaKapos commented 2 years ago

Problem Description

When TextInput has "focusable = false" you can't edit/copy/paste from it while you can in IOS/Android (and it looks like Web has no implementation of focusable).

On RNW, focusable to mapped to isTabStop and isEnabled (with isTabStop making the TextInput not being able to tab through or edit). Focusable is also the only way to access isEnabled and the visuals that come with it. We should discuss what properties we want focusable to be linked too for TextInput and if there's a better property to expose isEnabled.

Steps To Reproduce

  1. Set any TextInput to with focusable = false, you won't be able to edit it

Expected Results

You should be able to edit a TextInput with focusable="false"

CLI version

npx react-native --version

Environment

npx react-native info

Target Platform Version

10.0.19041

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2019

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

https://snack.expo.dev/@tatianak/textinput-focusable

chrisglein commented 2 years ago

Potentially related: #9826 #9327. @TatianaKapos can you build out a little table of what each platform is doing and what Windows is doing so it's clear what is wrong with Windows vs. what could be wrong with other platforms.

ghost commented 2 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

AgneLukoseviciute commented 2 years ago

Looks like this was unintentionally closed out, @TatianaKapos fyi. Reopening it.

ghost commented 2 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

AgneLukoseviciute commented 2 years ago

Putting it on the backlog so this doesn't get closed out again.