search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.11k stars 1.13k forks source link

Add BigInt and NativeState APIs #10723

Open TatianaKapos opened 1 year ago

TatianaKapos commented 1 year ago

Problem Description

Latest integrations added more methods to BigInt and a API for setting/getting Native State. Unfortunately, Hermes versioning is still being worked through and there wasn't a way to match JSI at that point in time causing an JSI ABI break.

Currently we override the necessary JSI files to get built to work.

https://github.com/facebook/react-native/commit/a21a1f845bd854f01cac905a4737a360cca0cd12 https://github.com/facebook/react-native/commit/61792339657b12f43318e842aba48c7043e40168

Steps To Reproduce

  1. Remove JSI overrides in ReactCommonTemp
  2. Try to build react-native-windows
  3. If you add the BigInt and NativeState APIs, chakra will run fine but hermes will break after opening the app

Expected Results

No response

CLI version

npx react-native --version

Environment

npx react-native info

Target Platform Version

No response

Target Device(s)

No response

Visual Studio Version

No response

Build Configuration

No response

Snack, code example, screenshot, or link to a repository

No response

TatianaKapos commented 1 year ago

@vmoroz I believe you were working through the Hermes versioning, is there an update to how we can match up JSI versioning and remove the overrides?

vmoroz commented 1 year ago

@vmoroz I believe you were working through the Hermes versioning, is there an update to how we can match up JSI versioning and remove the overrides?

@TatianaKapos, sorry, I was stuck with RNW C# issues. I will provide the new Hermes builds in the beginning of the coming week.

TatianaKapos commented 7 months ago

This hasn't been asked for yet, do we want to move this to the backlog?