search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.31k stars 1.14k forks source link

Enable passing borderRadius prop to Flyout control #12959

Open MicrosoftNik opened 6 months ago

MicrosoftNik commented 6 months ago

Summary

The current Flyout control does not support the passing of a borderRadius prop. If a View inside the Flyout control has a borderRadius, the rectangular corners of the Flyout control become clearly visible at the corners of the View.

Motivation

The current Flyout control does not meet visual standards when used with Views that have rounded corners.

Basic Example

No response

Open Questions

No response

chrisglein commented 6 months ago

Said Andrew:

I'd guess that the flyout viewmanager would have to forward the corner radius properties to the correct XAML elements. https://github.com/microsoft/react-native-windows/blob/72c9d7f8592a7a3e71e4da83a8e33e7d603477a8/vnext/Microsoft.ReactNative/Views/FlyoutViewManager.cpp#L295