search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.11k stars 1.13k forks source link

Remove Patch in TextInputExample.windows.js After React Alter TextInput Children #13303

Open chiaramooney opened 1 month ago

chiaramooney commented 1 month ago

An edit to TextInputSharedExamples.windows.js created an error in our E2E tests because the example was not written in valid TextInput format. Example was changed in 5/31 integration to resume successful E2E tests.

Meta has decided to alter React to accept raw text children for the TextInput appointment. Thus they are leaving the example as is until that change goes through. We should remove our patch in TextInputExample.js once React is changes. See #13342 for the patch.

Commit: https://github.com/facebook/react-native/commit/c046198cc9ad9b3b7bf1b94fd1d8915681681a6e Integration: https://github.com/microsoft/react-native-windows/pull/13298

chiaramooney commented 3 weeks ago

Upstream PR filed: https://github.com/facebook/react-native/pull/44883