search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.11k stars 1.13k forks source link

Unfork `CallbackWrapper.h` and `TurboModuleUtils.h` #13399

Open Yajur-Grover opened 1 week ago

Yajur-Grover commented 1 week ago

Summary

During this integration from March 2022, TurboModuleUtils.h and CallbackWrapper.h were forked due to the same path issue in #13391, with the path for TurboModuleUtils.h having two ReactCommon directories. This issue tracks the creation of these forks, as there was no issue created originally.

Motivation

Track as part of integration process for eventual removal

Basic Example

No response

Open Questions

No response

chrisglein commented 1 week ago

Proposed next action: Remove these forks and see what error we get, in order to find out the original reason for the forks.

Yajur-Grover commented 1 week ago

Tried removing the forks and building playground and got the following results:

Removing both forks:

Error C1083 Cannot open include file: 'react/bridging/CallbackWrapper.h': No such file or directory ReactNativePicker C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\CallbackWrapper.h 11

Removing just TurboModuleUtils.h fork:

Error C1083 Cannot open include file: 'react/bridging/CallbackWrapper.h': No such file or directory PlaygroundNativeModules C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\CallbackWrapper.h 11
Error C1083 Cannot open include file: 'react/bridging/CallbackWrapper.h': No such file or directory ReactNativePicker C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\CallbackWrapper.h 11
Error C1083 Cannot open include file: 'react/bridging/CallbackWrapper.h': No such file or directory playground C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\CallbackWrapper.h 11

Removing just CallbackWrapper.h fork:

Error C1083 Cannot open include file: 'react/bridging/LongLivedObject.h': No such file or directory PlaygroundNativeModules C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\bridging\CallbackWrapper.h 14
Error C1083 Cannot open include file: 'react/bridging/LongLivedObject.h': No such file or directory ReactNativePicker C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\bridging\CallbackWrapper.h 14
Error C1083 Cannot open include file: 'react/bridging/LongLivedObject.h': No such file or directory playground C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\bridging\CallbackWrapper.h 14

From these errors, we can assume that the original reason for the forks was due to the path of TurboModuleUtils.h including two ReactCommon directories.