search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.24k stars 1.13k forks source link

Fabric e2etests for large snapshots are broken #13436

Open TatianaKapos opened 1 month ago

TatianaKapos commented 1 month ago

Problem Description

Currently affecting main and 0.75

Broken Tests FlatList - Basic ScrollView - refresh Control SectionList - Scrollable

While working on the 0.75 branch these tests broke due to an Invalid string length error. I'm thinking it's because these are the only tests with 1000+ items and the toJson() function must have put a cap on what it can process but further investigation is needed. Check pages out locally and they render/work as intended

image

Steps To Reproduce

  1. Run tests on 0.75 branch
  2. Look at Pipeline (https://dev.azure.com/ms/react-native-windows/_build/results?buildId=592440&view=logs&j=20253376-38f7-5084-b900-818d1e6181d3&t=e4bc6543-c5eb-5bc9-6033-5ab4b4216285)

Expected Results

No response

CLI version

npx react-native -v

Environment

npx react-native info

Community Modules

No response

Target Platform Version

None

Target Device(s)

No response

Visual Studio Version

None

Build Configuration

None

Snack, code example, screenshot, or link to a repository

No response

Yajur-Grover commented 1 month ago

This issue is also present on the 6/18 integration, and I have commented the tests out pending a fix for this error. Verified the affected pages in the Tester App render as expected. However, on the SectionList example, when clicking on the 'scroll to' button to go to the listed section, all the buttons directed me to the top, rather than a specific individual section. @TatianaKapos did you see this on your preview branch as well?

TatianaKapos commented 1 month ago

@Yajur-Grover let me double check! Are you seeing this on Paper/Fabric? We may need to see if it's coming from the integration or if it's been broken on main.

Yajur-Grover commented 1 month ago

Was seeing it on RNTesterApp-Fabric. Will check the app on main as well.

jonthysell commented 1 week ago

@TatianaKapos Has this been resloved for 0.75?

TatianaKapos commented 1 week ago

@jonthysell nope! We can put this on the backlog since this is also affecting main not just 0.75