search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.36k stars 1.14k forks source link

Unfork `EventQueueProcessor.cpp` and `TimerManager.cpp` #13516

Open jonthysell opened 3 months ago

jonthysell commented 3 months ago

Problem Description

Getting C4715 not all control paths return a value warnings turning into errors due to new switches with enums that don't have a default return value.

Link to the integration where the error originated

https://github.com/microsoft/react-native-windows/pull/13508

Link to commit

https://github.com/facebook/react-native/commit/404f323359f9af469ba60132d802ffa0b2d72675

https://github.com/facebook/react-native/commit/a8a76f9bfab4aaefedf58b7fbcbea8efa7850e8b

Forked files

  1. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\react\renderer\core\EventQueueProcessor.cpp
  2. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\react\runtime\TimerManager.cpp

Upstream PR

https://github.com/facebook/react-native/pull/45827

Build Configuration

None

jonthysell commented 3 months ago

This was merged upstream on Aug 12th, so we should be able to unfork when we catch up to that build.