search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.4k stars 1.14k forks source link

Fix or deprecate playground-win32-packaged.sln #13692

Open jonthysell opened 2 months ago

jonthysell commented 2 months ago

Problem Description

I am unable to build this solution locally, and as far as I can see, this solution has never been built as a part of CI.

I don't think we need it, can we remove it from the repo?

Steps To Reproduce

  1. Open playground-win32-packaged.sln in VS
  2. Build the solution.

Expected Results

No response

CLI version

14.0.0-alpha.11

Environment

info Fetching system and libraries information...
System:
  OS: Windows 11 10.0.26100
  CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
  Memory: 7.71 GB / 15.84 GB
Binaries:
  Node:
    version: 18.18.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.22
    path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
  npm:
    version: 9.8.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
    Versions:
      - 10.0.19041.0
      - 10.0.22000.0
      - 10.0.22621.0
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.11.35303.130 (Visual Studio Enterprise 2022)
Languages:
  Java: Not Found
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Community Modules

No response

Target Platform Version

None

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2022

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

Errors just opening the solution:

"C:\code\rnw\packages\playground\windows\playground-win32-packaged.sln" (Restore target) (1) ->
(Restore target) ->
  C:\code\rnw\packages\playground\windows\Playground-win32 (Package)\Playground-win32 (Package).wapproj : error NU1201:
 Project Playground-Win32 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763). Project Playground-Win32 supp
orts: native (native,Version=v0.0) [C:\code\rnw\packages\playground\windows\playground-win32-packaged.sln]
  C:\code\rnw\packages\playground\windows\Playground-win32 (Package)\Playground-win32 (Package).wapproj : error NU1201:
 Project Playground-Win32 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-arm. Project Playgroun
d-Win32 supports: native (native,Version=v0.0) [C:\code\rnw\packages\playground\windows\playground-win32-packaged.sln]
  C:\code\rnw\packages\playground\windows\Playground-win32 (Package)\Playground-win32 (Package).wapproj : error NU1201:
 Project Playground-Win32 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-arm-aot. Project Playg
round-Win32 supports: native (native,Version=v0.0) [C:\code\rnw\packages\playground\windows\playground-win32-packaged.s
ln]
  C:\code\rnw\packages\playground\windows\Playground-win32 (Package)\Playground-win32 (Package).wapproj : error NU1201:
 Project Playground-Win32 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-arm64-aot. Project Pla
yground-Win32 supports: native (native,Version=v0.0) [C:\code\rnw\packages\playground\windows\playground-win32-packaged
.sln]
  C:\code\rnw\packages\playground\windows\Playground-win32 (Package)\Playground-win32 (Package).wapproj : error NU1201:
 Project Playground-Win32 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-x64. Project Playgroun
d-Win32 supports: native (native,Version=v0.0) [C:\code\rnw\packages\playground\windows\playground-win32-packaged.sln]
  C:\code\rnw\packages\playground\windows\Playground-win32 (Package)\Playground-win32 (Package).wapproj : error NU1201:
 Project Playground-Win32 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-x64-aot. Project Playg
round-Win32 supports: native (native,Version=v0.0) [C:\code\rnw\packages\playground\windows\playground-win32-packaged.s
ln]
  C:\code\rnw\packages\playground\windows\Playground-win32 (Package)\Playground-win32 (Package).wapproj : error NU1201:
 Project Playground-Win32 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-x86. Project Playgroun
d-Win32 supports: native (native,Version=v0.0) [C:\code\rnw\packages\playground\windows\playground-win32-packaged.sln]
  C:\code\rnw\packages\playground\windows\Playground-win32 (Package)\Playground-win32 (Package).wapproj : error NU1201:
 Project Playground-Win32 is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-x86-aot. Project Playg
round-Win32 supports: native (native,Version=v0.0) [C:\code\rnw\packages\playground\windows\playground-win32-packaged.s
ln]
acoates-ms commented 2 months ago

Yes we should remove it. We never fully supported running paper in a win32 app. Now that fabric does it out of the box, there is no need for this project.

chrisglein commented 2 months ago

Agreed. We will deprecate.