search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.36k stars 1.14k forks source link

Update some packages*.json files after the WinAppSDK udpate #14056

Closed JesseCol closed 2 weeks ago

JesseCol commented 3 weeks ago

Description

I did a WinAppSDK update recently, there are some packages*.json files that I missed when doing that update.

Type of Change

Why

Without this change, the "e2e-test-app-fabric" doesn't build successfully.

What

This change modifies some *.json files so the new version of WindowsAppSDK is the expected version.

I found and ran the script "NuGetRestoreForceEvaluateAllSolutions.ps1"

Testing

cd packages\e2e-test-app-fabric yarn windows --no-launch --no-deploy

Microsoft Reviewers: Open in CodeFlow
Yajur-Grover commented 3 weeks ago

Looks like SampleAppFabric is also on the old WinAppSDK: https://github.com/microsoft/react-native-windows/blob/a9afb5fddac4fb8741bb27de14aa563ddb35c254/packages/sample-app-fabric/windows/SampleAppFabric/packages.lock.json#L85

JesseCol commented 3 weeks ago

Looks like SampleAppFabric is also on the old WinAppSDK:

https://github.com/microsoft/react-native-windows/blob/a9afb5fddac4fb8741bb27de14aa563ddb35c254/packages/sample-app-fabric/windows/SampleAppFabric/packages.lock.json#L85

Thanks! I've now found and ran the script "NuGetRestoreForceEvaluateAllSolutions.ps1" which does what we need. I've verified that after this there are no references to the old version number (1.5.240227000).

JesseCol commented 3 weeks ago

/azp run

azure-pipelines[bot] commented 3 weeks ago
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).
JesseCol commented 3 weeks ago

/azp run

azure-pipelines[bot] commented 3 weeks ago
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).
JesseCol commented 2 weeks ago

LGTM! Do we also need to backport this to 0.76?

Thanks for looking! Yes, looks like we should backport to 0.76 because the first part of the WinAppSDK update is there. Can you point me to instructions?