Created a new cpp-lib project and noticed that we didn't add the "windows" folder to the file list so they're published in the NPM packages.
We should also make sure to not publish NuGet package.lock.json files (or even check them in by default) so end users don't end up in situations where their build fails because of old lock files.
Steps To Reproduce
Create a new library with the cpp-lib template
Expected Results
No response
CLI version
15.0.0-alpha.2
Environment
info Fetching system and libraries information...
System:
OS: Windows 11 10.0.26100
CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
Memory: 6.43 GB / 15.84 GB
Binaries:
Node:
version: 18.18.0
path: C:\Program Files\nodejs\node.EXE
Yarn:
version: 3.6.1
path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm:
version: 9.8.1
path: C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK: Not Found
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
AllowAllTrustedApps: Enabled
Versions:
- 10.0.19041.0
- 10.0.22000.0
- 10.0.22621.0
IDEs:
Android Studio: Not Found
Visual Studio:
- 17.11.35327.3 (Visual Studio Enterprise 2022)
Languages:
Java: Not Found
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 15.0.0-alpha.2
wanted: 15.0.0-alpha.2
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.76.0
wanted: 0.76.0
react-native-windows:
installed: 0.76.0
wanted: 0.76.0
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: Not found
newArchEnabled: Not found
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
info React Native v0.76.1 is now available (your project is running on v0.76.0).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.76.1
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.76.0&to=0.76.1
info For more info, check out "https://reactnative.dev/docs/upgrading?os=windows".
Community Modules
No response
Target Platform Version
10.0.22621
Target Device(s)
Desktop
Visual Studio Version
Visual Studio 2022
Build Configuration
Debug
Snack, code example, screenshot, or link to a repository
Problem Description
Created a new cpp-lib project and noticed that we didn't add the "windows" folder to the file list so they're published in the NPM packages.
We should also make sure to not publish NuGet package.lock.json files (or even check them in by default) so end users don't end up in situations where their build fails because of old lock files.
Steps To Reproduce
cpp-lib
templateExpected Results
No response
CLI version
15.0.0-alpha.2
Environment
Community Modules
No response
Target Platform Version
10.0.22621
Target Device(s)
Desktop
Visual Studio Version
Visual Studio 2022
Build Configuration
Debug
Snack, code example, screenshot, or link to a repository
https://github.com/jonthysell/native-module-sample