Popup (non light-dismiss) - can't Tab in/out of a Popup

microsoft / react-native-windows

A framework for building native Windows apps with React.

https://microsoft.github.io/react-native-windows/

Other

16.26k stars 1.14k forks source link

Popup (non light-dismiss) - can't Tab in/out of a Popup #3006

Open chrisglein opened 5 years ago

chrisglein commented 5 years ago

Splitting out from #2107

Tabbing in: This is an issue with XAML. But it's exacerbated in RNW because all Popups are unparented so you see this all the time instead of sometimes. XAML might fix this with WinUI 3 but we may want to workaround.

Tabbing out:

Popup (non light-dismiss) - should not trap focus (currently, always traps focus, which is correct for light-dismiss case)

aschultz commented 4 years ago

@chrisglein I'm working on popups and modals in my app right now, so I'd like to take a stab at a partial fix.

I'm thinking of adding a ContentControl as the first child of the Popup and auto-focusing that when the Popup opens. That will steal focus rather than allowing tabbing in and out, but it seems better than no access at all.

rectified95 commented 3 years ago

@chrisglein What is the correct behavior here? Currently, when a popup is open it traps focus. Is 'tabbing into a popup' about being able to tab in/out of an open one?

chrisglein commented 3 years ago

@chrisglein What is the correct behavior here? Currently, when a popup is open it traps focus. Is 'tabbing into a popup' about being able to tab in/out of an open one?

My comments on this are from over a year ago and I believe were also made mid-meeting (aka I was channeling the collective) :(. Tagging @harinikmsft in case she remembers or has put more recent thought into this through the focus zone discussions. I'd certainly say as is this issue is lacking a specific scenario/repro to measure success. XAML flyouts seem to err towards trapping focus.