search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.27k stars 1.14k forks source link

Have Bot Automatically Mark Changes to Template as Breaking Changes #5018

Open NickGerleman opened 4 years ago

NickGerleman commented 4 years ago

Changes to our template will generally need to be performed by users as well. We should automatically add the Breaking Change label to PRs touching template files to help documentation. Better to have false positives here than false negatives.

chrisglein commented 4 years ago

@NickGerleman tell me which paths and I'll update the bot.

NickGerleman commented 4 years ago

@chrisglein the path to template files is vnext\local-cli\generator-windows\templates

NickGerleman commented 4 years ago

We could consider having edits to any IDL files add the tag, since this generally also means a breaking public API change. Might be too agressive, but also seems to be better to have false positives than negatives. Thoughts @jonthysell ?

chrisglein commented 4 years ago

From Jon: "We should also add a codeowners to that dir, with a sub-team of template maintainers (like the sub-team we have for ABI owners on idl files)."