search

microsoft / react-native-windows

A framework for building native Windows apps with React.
https://microsoft.github.io/react-native-windows/
Other
16.34k stars 1.14k forks source link

For RNW >= 0.68, the CLI should throw a warning if the app is still using packages.config #9570

Open jonthysell opened 2 years ago

jonthysell commented 2 years ago

Summary

If someone runs any of our CLI commands, we should detect if the app is using packages.config, and throw a warning that we're moving to PackageReferences, with a link to relevant upgrade documentation

Motivation

With the move to PackageReference, we want to reduce our support of packages.config files. We should start warning people of our intentions, and point to documentation on how they upgrade/fix their app projects.

We shouldn't error outright, as we expect modules to lag in making this upgrade, and our guidance plan is to keep a packages.config to load the modules's nugets, as per the docs here: https://github.com/microsoft/react-native-windows-samples/pull/628

Basic Example

No response

Open Questions

No response

jonthysell commented 2 years ago

@JunielKatarn, FYI because this concerns the PackageReference work.

JunielKatarn commented 2 years ago

Noted. I'll be addressing all PackageReference integration issues this week.

Khalef1 commented 2 years ago

@JunielKatarn - this is still tagged for the 0.68 release. Given that 0.68 is out at this point, are you planning to backport the change or submit to a newer release?

JunielKatarn commented 2 years ago

Backport, if approved.