Open kg-currenxie opened 4 years ago
Is this project dead? Not even a response
Not dead but not moving terribly fast no, at last check Microsoft was pretty deeply invested in react-native / reactxp but I'm not sure what the current is @berickson1 ?
@kg-currenxie -- it looks like you found the issue! I think we just need to connect a native-common implementation that uses ReactNative's NativeStatusBarManager
Thoughts @mikehardy ?
Seems about right and I wouldn't be surprised if @kg-currenxie doesn't already have this locally integrated via patch-package ;-), should be a quick PR Kristian?
Seems about right and I wouldn't be surprised if @kg-currenxie doesn't already have this locally integrated via patch-package ;-), should be a quick PR Kristian?
Sorry, no patch-package for this one :) Just using RN's own at the moment (component not used on the web anyway) 🙈 🙈 🙈
If somebody wants to contribute this fix, I'd be happy to help review and get it slotted into the next release!
Gifs:
Using React-Native's component works fine in Android, and does actually change the text/icon colors.
Edit
Found this
https://github.com/microsoft/reactxp/blob/master/src/android/StatusBar.ts#L34
But React Native has this implemented:
https://github.com/facebook/react-native/blob/master/Libraries/Components/StatusBar/StatusBar.js#L288
https://github.com/facebook/react-native/blob/master/Libraries/Components/StatusBar/NativeStatusBarManagerAndroid.js
Edit 2:
Works fine in Android using the React Native way.
In some component:
Would it make sense to just add
NativeStatusBarManager
in RXP'sStatusBar
?