RN 0.63 Button compatibility - useNativeDriver was not specified

[Frexuz]

React Native now complains if useNativeDriver wasn't specified when animating.

https://github.com/microsoft/reactxp/blob/3382b02e75f21b9af53cba888015b77d9392677c/src/native-common/Button.tsx#L372-L381

https://github.com/microsoft/reactxp/blob/3382b02e75f21b9af53cba888015b77d9392677c/src/native-common/Animated.tsx#L160-L167

I can PR, but not sure if it's safe to just add useNativeDriver: true?

[deregtd]

Not all animations can use native driver, so maybe we just need to force config.useNativeDriver to non-optional in typescript now.

[fbartho]

@deregtd that sounds like the right plan. -- I wish there was a cleaner API from react-native that would tell us if a particular Animation supports useNativeDriver. Then we could detect those cases and conditionally set the flag.

This feels like an API Wart from RN's side.

[deregtd]

API warts from react native are a significant portion of the reason ReactXP exists. :)

[Frexuz]

But the Button is only animating opacity in setOpacityTo. Why wouldn't this be ok?

 // reactxp/src/native-common/Button.tsx

 setOpacityTo(value: number, duration: number) { 
     Animated.timing( 
         this._opacityAnimatedValue!, 
         { 
             toValue: value, 
             duration: duration, 
             easing: Animated.Easing.InOut(), 
+            useNativeDriver: true, 
         }, 
     ).start(); 
 } 

[deregtd]

Ah, I misunderstood the suggestion. That change is okay, since the code appears to only animate opacity specifically in the button. But also we need to change the config's type to be nonoptional now to find any other broken spots.

[fbartho]

@Frexuz -- I think we should do this. Do you want to submit a PR for it?

[Frexuz]

@fbartho yep :)