microsoft / reactxp

Library for cross-platform app development.
https://microsoft.github.io/reactxp/
Other
8.29k stars 491 forks source link

Please explain how to upgrade from 1.6.1 to 2.0.0 #1256

Open omatrot opened 3 years ago

omatrot commented 3 years ago

I would like to have a page in the documentation to explain how to upgrade from the previous version to the next one. Thanks in advance.

mikehardy commented 3 years ago

https://github.com/microsoft/reactxp/releases/tag/2.0.0 has the notes but they are not that prescriptive

I think the only thing really necessary is to move to the external packages for netinfo and webview if you are using them

https://github.com/microsoft/reactxp/tree/2.0.0/extensions

that would be (for me, via yarn) yarn add reactxp-webview reactxp-netinfo and...that is probably it?

omatrot commented 3 years ago

I've tried to upgrade to resub 2.3.0 first, but I still have the AsyncStorage Warning... I'll work on this remembering every step along the way to improv the docs.

omatrot commented 3 years ago

I've successfully upgraded to version 2.0.0. My app runs but fails in the navigation code, on iOS and Android:

TypeError: undefined is not an object (evaluating '_iterator[typeof Symbol === "function" ? Symbol.iterator : "@@iterator"]')

This error is located at:
    in Capture (at RootView.tsx:401)
    in SceneView (at NavigationCard.js:141)
    in RCTView (at View.js:45)
    in View (at createAnimatedComponent.js:151)
    in AnimatedComponent (at NavigationCard.js:135)
    in NavigationCard (at NavigationPointerEventsContainer.js:92)
    in Container (at NavigationCardStack.js:345)
    in RCTView (at View.js:45)
    in View (at NavigationCardStack.js:310)
    in RCTView (at View.js:45)
    in View (at NavigationCardStack.js:309)
    in RCTView (at View.js:45)
    in View (at NavigationTransitioner.js:232)
    in NavigationTransitioner (at NavigationCardStack.js:254)
    in NavigationCardStack (created by NavigatorImpl)
    in NavigatorImpl (at RootView.tsx:205)
    in RCTView (at View.js:45)
    in View (at createAnimatedComponent.js:151)
    in AnimatedComponent (at index.js:153)
    in RCTView (at View.js:45)
    in View (at index.js:247)
    in SideMenu (at RootView.tsx:200)
    in RCTView (at View.js:45)
    in View (created by View)
    in View (at RootView.tsx:194)
    in RootView (at App.tsx:165)
    in RCTView (at View.js:45)
    in View (created by View)
    in View (at App.tsx:156)
    in App (at src/index.tsx:20)
    in RCTView (at View.js:45)
    in View (created by RootViewUsingStore)
    in RCTView (at View.js:45)
    in View (at createAnimatedComponent.js:151)
    in AnimatedComponent (created by RootViewUsingStore)
    in RootViewUsingStore (at renderApplication.js:35)
    in RCTView (at View.js:45)
    in View (at AppContainer.js:98)
    in RCTView (at View.js:45)
    in View (at AppContainer.js:115)
    in AppContainer (at renderApplication.js:34)

bubbles
    Capture.tsx:808:4
render
    Capture.tsx:350:54
render
    ComponentBase.js:74:51
_tryFinally
    AutoSubscriptions.js:163:22
AutoSubscribeWrapper
    AutoSubscriptions.js:129:33
finishClassComponent
    ReactNativeRenderer-dev.js:11581:21
updateClassComponent
    ReactNativeRenderer-dev.js:11509:4
performUnitOfWork
    ReactNativeRenderer-dev.js:17276:21
workLoop
    ReactNativeRenderer-dev.js:17316:41
renderRoot
    ReactNativeRenderer-dev.js:17417:15
performWorkOnRoot
    ReactNativeRenderer-dev.js:18423:17
performWork
    ReactNativeRenderer-dev.js:18324:24
performSyncWork
    ReactNativeRenderer-dev.js:18285:14
requestWork
    ReactNativeRenderer-dev.js:18169:19
scheduleWork
    ReactNativeRenderer-dev.js:17969:16
enqueueSetState
    ReactNativeRenderer-dev.js:6934:17
<unknown>
    react.development.js:325:31
<unknown>
    NavigatorExperimentalDelegate.js:90:29
<unknown>
    Navigator.js:109:50
<unknown>
    RootView.tsx:675:49
saveData$
    Settings.tsx:253:39
tryCatch
    runtime.js:63:44
invoke
    runtime.js:293:30
tryCatch
    runtime.js:63:44
invoke
    runtime.js:154:28
<unknown>
    runtime.js:164:19
tryCallOne
    core.js:37:14
<unknown>
    core.js:123:25
_callTimer
    JSTimers.js:152:14
_callImmediatesPass
    JSTimers.js:200:17
callImmediates
    JSTimers.js:473:30
callImmediates
    [native code]:0
__callImmediates
    MessageQueue.js:337:6
<unknown>
    MessageQueue.js:135:6
__guard
    MessageQueue.js:314:10
flushedQueue
    MessageQueue.js:134:17
flushedQueue
    [native code]:0
invokeCallbackAndReturnFlushedQueue
    [native code]:0

If some one could help that would be nice. Thanks in advance.