microsoft / reactxp

Library for cross-platform app development.
https://microsoft.github.io/reactxp/
Other
8.29k stars 491 forks source link

[Suggestion] Restructure ReactXP as a lerna monorepo to facilitate testing internal projects #844

Open luisnaranjo733 opened 6 years ago

luisnaranjo733 commented 6 years ago

I think maintaining ReactXP would be easier if it were structured as a lerna monorepo.

Example scenario today:

Same scenario with a lerna monorepo

For example, see this snippet from Wix's Detox framework contribution guide

For all the internal projects (detox, detox-cli, demos, test) lerna will create symbolic links in node_modules instead of npm copying the content of the projects. This way, any change you do on any code is there immediately. There is no need to update node modules or copy files between projects.

erictraut commented 6 years ago

I don't know if lerna is the answer, but I agree that this is a problem. Another potential solution is to have the RXPTest sample directly import from the core ReactXP sources rather than importing the published version.

fbartho commented 4 years ago

I'm motivated to get some sort of improved tooling for testing, but I think we can get that done with simpler tools than lerna.

Was there anything further you wanted to request in this ticket @luisnaranjo733 ?

See also #1233

luisnaranjo733 commented 4 years ago

Nope! My intent was to outline the problem, not to be prescriptive about the solution. Thanks!