search

microsoft / redux-dynamic-modules

Modularize Redux by dynamically loading reducers and middlewares.
https://redux-dynamic-modules.js.org
MIT License
1.07k stars 116 forks source link

Allow user to pass custom epicMiddleware to epicManager #141

Open Lucklyric opened 4 years ago

Lucklyric commented 4 years ago

It is common to have an epicMiddleware that includes dependencies. In the current observable extension, it creates a default epicMiddleware which will not work for users with custom epicMiddleware. In this PR, I simply added an argument to getObservableExtensionto allow user to pass custom epicMiddlewareto epicManger in the extension.

export function getObservableExtension(_epicMiddleware: EpicMiddleware<any>): IExtension;
msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

olegshilov commented 4 years ago

any news here?

LFFATE commented 4 years ago

well. it's also will solve my problem https://github.com/microsoft/redux-dynamic-modules/issues/145 So waiting for review this PR