search

microsoft / redux-dynamic-modules

Modularize Redux by dynamically loading reducers and middlewares.
https://redux-dynamic-modules.js.org
MIT License
1.07k stars 116 forks source link

Fix undefined state on first render after dynamicially loading module in react-redux v6 #59

Closed navneet-g closed 5 years ago

navneet-g commented 5 years ago

See #27 The primary change is in DynamicModuleLoader.tsx. The rest is adding another sample project that repro'd the issue.

https://github.com/Microsoft/redux-dynamic-modules/pull/59/files#diff-3ceb15cf807c230eeddb28876224070f

navneet-g commented 5 years ago

Why are you incrementing version now?

this is new published version as I published to npm

abettadapur commented 5 years ago

Why did you publish before closing this PR??

navneet-g commented 5 years ago

Why did you publish before closing this PR??

You had already approved, and the publish happened in the same branch not in master

abettadapur commented 5 years ago

for the future, we should wait till we merge to master and always publish from them. IMO, its bad practice to be publishing to npm from feature branches

navneet-g commented 5 years ago

for the future, we should wait till we merge to master and always publish from them. IMO, its bad practice to be publishing to npm from feature branches

Sure.

abettadapur commented 5 years ago

I modified the lerna.json file to prevent this in the future :)