search

microsoft / referencesource

Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework
https://referencesource.microsoft.com/
MIT License
3.17k stars 1.27k forks source link

SortedList IDictionary ctor to IReadOnlyDictionary #109

Open craigwardman opened 5 years ago

craigwardman commented 5 years ago

Is there any reason why the ctor which creates a SortedList from a dictionary cannot use IReadOnlyDictionary instead of IDictionary?

https://github.com/microsoft/referencesource/blob/e0bf122d0e52a42688b92bb4be2cfd66ca3c2f07/mscorlib/system/collections/sortedlist.cs#L166

craigwardman commented 5 years ago

I've made the code changes locally to support this, I have an open issue with the API reviewers and plan to raise a PR into corefx repo if it is passed:

https://github.com/dotnet/corefx/issues/38395