search

microsoft / referencesource

Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework
https://referencesource.microsoft.com/
MIT License
3.13k stars 1.27k forks source link

GetSexagenaryYear is based on Lunisolar Date instead of Sexagenary Date #129

Closed samlishen closed 1 year ago

samlishen commented 4 years ago

The GetSexagenaryYear use Lunisolar Date to determine the Sexagenary Year. However, Sexagenary Calendar has different "New Year" as Lunisolar Calendar. The Sexagenary "New Year" should be Lichun(Feb. 4th/3rd) instead of Lunisolar New Year.

You can find reference document on Wikipedia(https://en.wikipedia.org/wiki/Sexagenary_cycle#Sexagenary_months).

https://github.com/microsoft/referencesource/blob/3b1eaf5203992df69de44c783a3eda37d3d4cd10/mscorlib/system/globalization/eastasianlunisolarcalendar.cs#L53

terrajobst commented 1 year ago

This repository does not accept feature requests or bug reports. To submit those, you need to go elsewhere: