search

microsoft / referencesource

Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework
https://referencesource.microsoft.com/
MIT License
3.17k stars 1.27k forks source link

Add System.Messaging sources #141

Closed karelz closed 4 years ago

karelz commented 4 years ago

Code for System.Messaging

karelz commented 4 years ago

@terrajobst can you please merge it? cc @HongGit @HeathAr @dasetser

karelz commented 4 years ago

@terrajobst can we merge it please? cc @danmosemsft

danmoseley commented 4 years ago

@karelz is there a code owner that can sign off here, for the sake of process?

I have merge powers and can do that.

danmoseley commented 4 years ago

Can we also tag the person who originally requested this, so they can confirm everything's here?

weloytty commented 4 years ago

Can we also tag the person who originally requested this, so they can confirm everything's here?

@danmosemsft I am not sure if you mean someone internal to MSFT, but I am the one who sent the original email after @karelz asked me to in https://github.com/dotnet/runtime/issues/16409#issuecomment-573334271 , and everything I need is in the commit.

karelz commented 4 years ago

@danmosemsft code owners in .NET Framework are tagged above: https://github.com/microsoft/referencesource/pull/141#issuecomment-647311853

danmoseley commented 4 years ago

OK - @HongGit @HeathAr @dasetser could one of you please sign off?

danmoseley commented 4 years ago

Done! Hope this is what you need @weloytty and apologies for the time it took.

weloytty commented 4 years ago

Thanks everyone for all of your help, I built everything and made the repo public, and just submitted to nuget a few minutes ago. This was a huge roadblock for us, I'm glad that we won't be stuck on .NET Framework forever.

danmoseley commented 4 years ago

Nice! cc @mconnew fyi.

mconnew commented 4 years ago

There's going to be some features in this which are broken. For example, you can use transactions with MSMQ but the implementation of System.Transactions in .NET Core doesn't work with MSDTC so that part of System.Messaging won't work. I'm not super familiar with the code base or even api so I'm not volunteering, but someone should go through the features supported by the api and work out what does and doesn't work and throw PlatformNotSupportedException on things which don't work instead of having everyone who consumes this api try and work out why their app isn't working as expected. Nevermind, just saw this is making the code available in reference source. I thought this was in dotnet/runtime

nehaheights commented 3 years ago

Hi all, This MSMQ.Messaging works well 👍 Thanks. Is there anything to support MSMQ with Masstransit in dotnet core ? I couldn't fine anything to support that.

zzti commented 2 years ago

When to support MSMQ in dotnet core ?

terrajobst commented 2 years ago

We still don't have plans to bring this to .NET Core. https://github.com/dotnet/runtime/issues/16409#issuecomment-541875447

fishjd commented 1 year ago

This has been accomplished: https://www.nuget.org/packages/MSMQ.Messaging/

danmoseley commented 1 year ago

nice -- thanks for sharing @fishjd.

linking the repo also https://github.com/weloytty/MSMQ.Messaging