microsoft / referencesource

Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework

https://referencesource.microsoft.com/

MIT License

3.17k stars 1.27k forks source link

Adds additional JS to System.Web.Extensions #143

Closed steveisok closed 4 years ago

steveisok commented 4 years ago

Fixes https://github.com/microsoft/referencesource/issues/121

READ BEFORE FILING

This repository is read-only and doesn't accept community pull requests.

MichaelKetting commented 4 years ago

@danmosemsft, @steveisok Thank you! I will verify the list sometime in the next couple of workdays.

MichaelKetting commented 4 years ago

@danmosemsft, do you happen to have a link to a publicly available copy of Nikhil Kothari's JS Utils? Or, would it be possible (i.e. legally, license-wise) to publish the copy you are using? As far as I can tell, that was the tool used to process/compile the JS and JSA files into their output format? Nikhil unfortunately removed them during a revamp of his homepage it was never published on Codeplex or Github as far as I can tell.

Thanks, Michael!

danmoseley commented 4 years ago

@michaelketting I'm not from that team so I don't know and likely @steveisok does not either.

Maybe @tratcher might know.

I don't think this should hold up merging this PR, right?

MichaelKetting commented 4 years ago

@danmosemsft Thank you for pinging the correct person. Regarding the merge: yes and no. we want to check that all the files are there, we'll now do this manually via some grep or something of the sort :) instead of just running the preprocesser/compiler and checking the entire output for equality against the .NET Framework embedded resources. We'll do this early in the upcoming week.