search

microsoft / referencesource

Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework
https://referencesource.microsoft.com/
MIT License
3.16k stars 1.27k forks source link

Missing System.Net.HttpClient source #75

Closed davidkeaveny closed 4 years ago

davidkeaveny commented 5 years ago

Is there a particular reason why System.Net.HttpClient does not appear in ReferenceSource? Its source is available at dotnet/corefx, but since it is not available at ReferenceSource, I am having major difficulties debugging an issue that I have (where the SendAsync method changes the request.RequestUri when it shouldn't).

elliott-beach commented 5 years ago

Yaaaas, this should be available so I can understand exactly what operations are doing!

karelz commented 5 years ago

Seems that the full Http subdirectory is missing :( ndp\fx\src\Net\System\Net\Http

IanKemp commented 5 years ago

@karelz I'm pretty sure that reference source isn't within your area of responsibility at MS, but given that issues filed in this repo seem to go nowhere, would you please consider taking it upon yourself to get this one, at least, resolved? Pretty please?

karelz commented 5 years ago

We started discussing that with the right people few weeks ago. And I used this +1 for another ping on action there. We will get to it. While painful, I can't invest my personal time here yet - I've got higher priority things burning I need to take care of first, sorry.

danmoseley commented 5 years ago

Fixed by https://github.com/Microsoft/referencesource/pull/105

This is not the same as being on source server, but you can manually point the debugger there.

danmoseley commented 5 years ago

@rbhanda you can close this.

cppcraze commented 4 years ago

Hey Danmose, how is this issue fixed? try search referencesource now (FX 4.8) https://referencesource.microsoft.com/#q=httpclient, httpclient still not there.

danmoseley commented 4 years ago

@cppcraze the website is not autogenerated from the repo. Right now we don't have a plan to update the website as it's manually done. The goal is to share the source -- it can be found on https://github.com/microsoft/referencesource as in the PR linked above.

danmoseley commented 4 years ago

@rbhanda can you please close this issue or better still give me permissions !