microsoft / referencesource

Source from the Microsoft .NET Reference Source that represent a subset of the .NET Framework
https://referencesource.microsoft.com/
MIT License
3.16k stars 1.27k forks source link

Missing Referencsource Files #96

Closed steveisok closed 4 years ago

steveisok commented 5 years ago

Tagging @karelz

I've ported the 4.6 version of webforms into Mono and have noticed there are a bunch of missing files. It would be great if you could get them added so that I can have a more complete port.

Here's the list:

asp_clientfiles

SmartNav.htm SmartNav.js WebForms.js WebUIValidation.js

System.Web.RegularExpressions

ALL

System.Configuration

Files

ConfigurationBuilder.cs ConfigurationBuilderChain.cs ConfigurationBuilderSettings.cs ConfigurationBuildersSection.cs ConfigurationStringConstants.cs IInternalConfigurationBuilderHost.cs

Resources

System.Configuration.resx

System.Web

Files

Cache/AggregateEnumerator.cs Cache/AspNetCache.cs Cache/CacheCommon.cs Cache/CacheGetOptions.cs Cache/CacheInsertOptions.cs Cache/CacheInternal.cs Cache/CacheKeyComparer.cs Cache/CacheMultiple.cs Cache/CacheSingle.cs Cache/CacheSizeMonitor.cs Cache/CacheStoreProvider.cs Cache/CacheExpires.cs Cache/CacheUsage.cs Cache/ExpiresBucket.cs Cache/ExpiresEntityRef.cs Cache/ExpiresEntry.cs Cache/ExpiresPage.cs Cache/ExpiresPageList.cs Cache/UsageBucket.cs Cache/UsageEntityRef.cs Cache/UsageEntry.cs Cache/UsageEntryLink.cs Cache/UsagePage.cs Cache/UsagePageList.cs Globalization/IStringLocalizerProvider.cs Globalization/ResourceFileStringLocalizerProvider.cs Globalization/StringLocalizerProviders.cs Hosting/ApplicationMonitors.cs Hosting/ICustomLoaderHelperFunctions.cs Hosting/CustomLoaderHelper.cs Hosting/CustomLoaderAttribute.cs ModelBinding/DisplayAttributeAdapter.cs ModelBinding/MaxLengthAttributeAdapter.cs ModelBinding/MinLengthAttributeAdapter.cs State/ISessionStateModule.cs Util/SecureHashCodeProvider.cs

Resources

GridView.js DetailsView.js
DetailsView.js TreeView.js
Menu.js

System.Web.ApplicationServices

Files

System.Web.Security/IMembershipHelper.cs System.Web.UI/KeyedList.cs System.Web.UI/KeyedListEnumerator.cs

System.Web.DynamicData

Files

Util/DisplayAttributeExtensions.cs Util/StringLocalizerUtil.cs

Resources

System.Web.DynamicData.DynamicControl.bmp System.Web.DynamicData.DynamicDataManager.bmp System.Web.DynamicData.DynamicEntity.bmp System.Web.DynamicData.DynamicHyperLink.bmp System.Web.DynamicData.DynamicValidator.bmp System.Web.Resources.DynamicDataResources.resx

System.Web.DataVisualization

Resources

System.Web.UI.DataVisualization.Charting.ChartControl.ico System.Web.UI.DataVisualization.Charting.Design.resx System.Web.UI.DataVisualization.Charting.SR.resx

System.Web.Extensions

Resources

System.Web.Resources.AtlasWeb.resx System.Web.Resources.ScriptLibrary.Res.debug.resx System.Web.Resources.ScriptLibrary.Res.resx

karelz commented 5 years ago

@terrajobst @richlander who can help with this request?

steveisok commented 5 years ago

Ping - Is this possible?

steveisok commented 5 years ago

Ping + 1 :-)

karelz commented 5 years ago

@richlander @terrajobst ping?

terrajobst commented 5 years ago

I’ll setup a meeting with you and the owners. We need to fix this more broadly.

karelz commented 5 years ago

Sounds good! cc @danmosemsft as FYI

steveisok commented 5 years ago

Did you guys have that meeting? If so, what were the outcomes?

karelz commented 5 years ago

Nope, I don't think it happened. @terrajobst can you please set it up?

steveisok commented 5 years ago

@karelz @terrajobst Assuming this is going to be tough to get to, would having reflected versions of the files be a problem? I'm all for getting the real files, but I also understand priorities. Thoughts?

steveisok commented 5 years ago

@karelz ping

danmoseley commented 5 years ago

@steveisok the outcome of the meeting I think is that we don't have time in the foreseeable future to find the files and do the necessary cleaning to put them on reference source. You should have access to the official .NET Framework sources internally, can you use those? Possibly even offer a PR to the referencesource repo, optionally.

steveisok commented 5 years ago

@danmosemsft yes, I didn’t realize I had access. Terrific!

MichaelKetting commented 5 years ago

I've also started to fiddle around with getting the reference sources to compile (for now, on Full Framework, but the intention is to put this on GitHub and get it to run on .NET Core *) ) and found the following additional missing files (might be some other's I missed):

System.Web

System.Web.Hosting

System.Web.Extensions

@steveisok The missing Cache-files: The referenc sources include cacheexpires.cspp and cacheusage.cspp which create some of the cache types from the first post. I'm not sure if there's actually a C# implementation of those.

*) Why not use Mono: I'm hoping to get a completely compatible implementation (including some private members I'm calling via Reflection) that can be used in mutli-targeting of an application for Full Framework and .NET Core and to also allow the usage with re-compiled Telerik components

steveisok commented 4 years ago

Good progress :-)

https://github.com/microsoft/referencesource/pull/118

danmoseley commented 4 years ago

Thanks @steveisok !

MichaelKetting commented 4 years ago

@steveisok Great, thanks a lot for this! May I ask if you had to reverse engineer or were you able to get the offical sources from Microsoft?

steveisok commented 4 years ago

@MichaelKetting They're official.

MichaelKetting commented 4 years ago

@steveisok Thanks again for organizing the file set. Am now much more complete when compiling System.Web.

I did notice that the JS-files for System.Web.Extensions are still missing: MicrosoftAjax.js MicrosoftAjaxApplicationServices.js MicrosoftAjaxComponentModel.js MicrosoftAjaxCore.js MicrosoftAjaxGlobalization.js MicrosoftAjaxHistory.js MicrosoftAjaxNetwork.js MicrosoftAjaxSerialization.js MicrosoftAjaxTimer.js MicrosoftAjaxWebForms.js MicrosoftAjaxWebServices.js Date.HijriCalendar.js Date.UmAlQuraCalendar.js MicrosoftAjax.debug.js MicrosoftAjaxApplicationServices.debug.js MicrosoftAjaxComponentModel.debug.js MicrosoftAjaxCore.debug.js MicrosoftAjaxGlobalization.debug.js MicrosoftAjaxHistory.debug.js MicrosoftAjaxNetwork.debug.js MicrosoftAjaxSerialization.debug.js MicrosoftAjaxTimer.debug.js MicrosoftAjaxWebForms.debug.js MicrosoftAjaxWebServices.debug.js Date.HijriCalendar.debug.js Date.UmAlQuraCalendar.debug.js MicrosoftAjax.js MicrosoftAjax.debug.js MicrosoftAjaxCore.js MicrosoftAjaxCore.debug.js MicrosoftAjaxWebForms.js MicrosoftAjaxWebForms.debug.js

Are you able to help with those, too? Should I create a new ticket for this? (Edit: I've now created #121 for this)

Thanks, Michael

Code-DJ commented 4 years ago

@steveisok were you able to find these #33 as well? Thanks!

steveisok commented 4 years ago

Yeah, although System.Web.RegularExpressions is a bit "interesting" ;-)

https://github.com/microsoft/referencesource/tree/master/regexes