rename method from Clone to clone inEngine class to match the java naming convention and definition in the java.lang.Object.

microsoft / regorus

Regorus - A fast, lightweight Rego (OPA policy language) interpreter written in Rust.

MIT License

130 stars 31 forks source link

rename method from Clone to clone inEngine class to match the java naming convention and definition in the java.lang.Object. #268

Closed balcanuc closed 3 months ago

balcanuc commented 3 months ago

rename method from Clone to clone in Engine class to match the java naming convention and definition in the java.lang.Object.

An alternative would be to mark the current Clone as @Deprecated and add a new method clone. As the fails happens on compile time and Regorus is not at a peak adoption, I think that just renaming the method is better.

anakrish commented 3 months ago

@balcanuc Thanks for the contribution. Can you rebase to the latest main to unblock testing this PR?

anakrish commented 3 months ago

Merging this since the blocking clippy issue already fixed in main and the rebased pr passes locally.