microsoft / retina

eBPF distributed networking observability tool for Kubernetes
https://retina.sh
MIT License
2.73k stars 207 forks source link

log: fix "unsupported value" error in a log line #309

Closed huntergregory closed 15 hours ago

huntergregory commented 6 months ago

zap.Any() does not support the field passed at packetparser/packetparser_linux.go:217

We should find another way to log the eth0Link:

level=info caller=packetparser/packetparser_linux.go:217 msg="Attaching Packetparser to eth0" goversion=go1.21.9 os=linux arch=amd64 numcores=4 hostname=aks-nodepool1-17703939-vmss000000 podname=retina-agent-cqnxv version=b8538dc apiserver=https://vakr-04-16-vakr-04-16-9b8218-ezit2obj.hcp.westus2.azmk8s.io:443 plugins=linuxutil,packetforward,packetparser,dns,dropreason eth0Link= eth0LinkError="unsupported value type"
roopeshsn commented 6 months ago

zap.Any() does not support the field passed at packetparser/packetparser_linux.go:217

We should find another way to log the eth0Link:

level=info caller=packetparser/packetparser_linux.go:217 msg="Attaching Packetparser to eth0" goversion=go1.21.9 os=linux arch=amd64 numcores=4 hostname=aks-nodepool1-17703939-vmss000000 podname=retina-agent-cqnxv version=b8538dc apiserver=https://vakr-04-16-vakr-04-16-9b8218-ezit2obj.hcp.westus2.azmk8s.io:443 plugins=linuxutil,packetforward,packetparser,dns,dropreason eth0Link= eth0LinkError="unsupported value type"

It's a netlink.Link interface right?

timraymond commented 5 months ago

@huntergregory is this still an issue? It seems like the offending log line has been changed to remove zap.Any entirely...

mereta commented 15 hours ago

@ibezrukavyi this one seem to eb outdated. Closing.