Enable cross compile builds for s390x and ppc on azure ci

microsoft / ripgrep-prebuilt

Builds ripgrep on Azure Pipelines for multiple platforms and makes the binaries available as Github releases

MIT License

46 stars 15 forks source link

Enable cross compile builds for s390x and ppc on azure ci #13

Closed Rohan-Shinde-98 closed 2 years ago

Rohan-Shinde-98 commented 2 years ago

Previously ppc and s390x binaries were released via Travis-CI however with the recent move to azure pipelines, the binaries are not published. This PR is in reference to https://github.com/microsoft/ripgrep-prebuilt/pull/2#issuecomment-931767970 to add a cross-compiled build for ppc & s390x binary on azure ci.

Attaching build pipeline status from my forked repo. https://dev.azure.com/RohanShinde/ripgrep-prebuilt/_build/results?buildId=77&view=results

ghost commented 2 years ago

All CLA requirements met.

svghadi commented 2 years ago

Hi @roblourens, please have a look.

roblourens commented 2 years ago

Thanks! Yeah, we aren't going to use Travis anymore. First glance looks fine, let me take another look later

ghatwala commented 2 years ago

@roblourens - any updates from your second look/review ? does this look good to now re-enable power+s390x binaries via azure pipeline ?

Rohan-Shinde-98 commented 2 years ago

Hi @roblourens after merging PR, the build pipeline is getting canceled for all the Linux jobs. Looks like the cause is ubuntu16.04 image is not available as it is deprecated, also the azure pipeline is giving the same warning as ##[warning]An image label with the label ubuntu-16.04 does not exist.

Any thoughts on this?

Below is the attached screenshot

roblourens commented 2 years ago

Fixed, thanks