search

microsoft / ripgrep-prebuilt

Builds ripgrep on Azure Pipelines for multiple platforms and makes the binaries available as Github releases
MIT License
46 stars 15 forks source link

Add s390x support & Setup multi-arch travis-ci job #2

Closed svghadi closed 4 years ago

svghadi commented 4 years ago

Add s390x support and migrate travis-ci job from vm based environment to lxd container environment.

ghost commented 4 years ago

CLA assistant check
All CLA requirements met.

svghadi commented 4 years ago

Please have a look. @roblourens

roblourens commented 4 years ago

...why? What is this for?

ghatwala commented 4 years ago

hey @roblourens , so we need this to enable eclipse/che-theia builds on s390x arch which needs ripgrep-prebuilt invoked via https://github.com/microsoft/vscode-ripgrep/blob/master/lib/postinstall.js#L41.

Once this PR is merged to enable s390x , we will be raising another one in vscode-ripgrep repo like - arch === 's390x' ? 's390x-unknown-linux-gnu'. Please let us know if you need more details to enable another arch just like you had enabled ppc64le in the past .

roblourens commented 4 years ago

Thanks, please give me this context up front next time, I don't just merge a PR with no explanation

ghatwala commented 4 years ago

@roblourens - Acknowledged , will ensure we do that in future. Also can you please update releases to have s390x tarball too. So that we can raise another PR to add s390x arch here - https://github.com/microsoft/vscode-ripgrep/blob/master/lib/postinstall.js#L41. ( cc- @kcrane )

roblourens commented 2 years ago

FYI, we will not be using Travis CI anymore, so the s390 and PPC architectures won't be built. If you need this, you could submit a PR that builds those archs in azure devops with the others