search

microsoft / ripgrep-prebuilt

Builds ripgrep on Azure Pipelines for multiple platforms and makes the binaries available as Github releases
MIT License
46 stars 15 forks source link

Remove `aarch64-unknown-linux-gnu` release asset #23

Open andreamah opened 1 year ago

andreamah commented 1 year ago

In https://github.com/microsoft/vscode-ripgrep/commit/a85a6872107d616942511ea4421f438608b6579a, we change vscode-ripgrep to only consume aarch64-unknown-linux-musl for arm64 linux and not the gnu version. If nobody is using it, we should remove it as a released asset.

andreamah commented 1 year ago

https://github.com/microsoft/ripgrep-prebuilt/pull/2 @Siddhesh-Ghadi @ghatwala We saw that you use these prebuilts for https://github.com/eclipse-che/che-theia. Would removing our aarch64-unknown-linux-gnu be an issue for you all?

ghatwala commented 1 year ago

hi @andreamah https://github.com/microsoft/ripgrep-prebuilt/pull/2/files here we had added support for power , z only and we wont be impacted at least by removing above but there may be others who are consuming this which we aren't aware of.

andreamah commented 1 year ago

I see, thanks for the quick response. Since this repo only really supports the vscode-ripgrep repo, others are responsible for any breakages that happen from changes to this repo.

I just wanted to reach out because I was told that Theia also uses it. 🙂