microsoft / ripgrep-prebuilt

Builds ripgrep on Azure Pipelines for multiple platforms and makes the binaries available as Github releases
MIT License
46 stars 15 forks source link

`arm-unknown-linux-gnueabihf` enforces a minimum GLIBC #24

Open andreamah opened 1 year ago

andreamah commented 1 year ago

Related: https://github.com/microsoft/vscode/issues/179121#issuecomment-1498077103

It seems like systems that use arm-unknown-linux-gnueabihf looks for GLIBC_2.29 despite vscode supporting lower GLIBC versions. This is since that prebuilt is still not statically compiled, so building it against ubuntu-latest likely increased the GLIBC version that it required from dynamically linked dependences.

We should try to make this prebuilt statically compiled by using the musl version, as we did with https://github.com/microsoft/vscode-ripgrep/issues/34

roblourens commented 1 year ago

If you have trouble with the real fix and you want to do a quick fix to get out in Insiders, maybe we can do something where we ship the old version of the binary just for this one arch, and the others continue using the latest.

deepak1556 commented 1 year ago

If you find there are perf costs to using musl, you can instead build on container targets that aligns the minimum GLIBC with VSCode server.

For armhf - we build on Debian buster https://github.com/microsoft/vscode-linux-build-agent/blob/main/buster-armhf/Dockerfile For arm64 - we build on Centos7 Devtoolset8 https://github.com/microsoft/vscode-linux-build-agent/blob/main/centos7-devtoolset8-arm64/Dockerfile